Skip to content

[Frontend] Expose revision arg in OpenAI server #8501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 16, 2024
Merged

[Frontend] Expose revision arg in OpenAI server #8501

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7348f61
Expose revision arg in OpenAPI server
lewtun Sep 16, 2024
65c0925
Fix style
lewtun Sep 16, 2024
e85e5a4
Fix mypy
lewtun Sep 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions vllm/entrypoints/openai/api_server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,8 +69,10 @@


def model_is_embedding(model_name: str, trust_remote_code: bool,
quantization: Optional[str]) -> bool:
quantization: Optional[str],
revision: Optional[str]) -> bool:
return ModelConfig(model=model_name,
revision=revision,
tokenizer=model_name,
tokenizer_mode="auto",
trust_remote_code=trust_remote_code,
Expand Down Expand Up @@ -130,7 +132,7 @@ async def build_async_engine_client_from_engine_args(
# If manually triggered or embedding model, use AsyncLLMEngine in process.
# TODO: support embedding model via RPC.
if (model_is_embedding(engine_args.model, engine_args.trust_remote_code,
engine_args.quantization)
engine_args.quantization, engine_args.revision)
or disable_frontend_multiprocessing):
engine_client = AsyncLLMEngine.from_engine_args(
engine_args, usage_context=UsageContext.OPENAI_API_SERVER)
Expand Down
Loading