Skip to content

[Bugfix] Validate SamplingParam n is an int #8548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 20, 2024
Merged

[Bugfix] Validate SamplingParam n is an int #8548

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7bf973b
Enforce SamplingParam 'n' is an int
saumya-saran Sep 17, 2024
5548dfa
Merge remote-tracking branch 'upstream/main'
saumya-saran Sep 17, 2024
2f49b72
Remove extra space
saumya-saran Sep 17, 2024
6c19a10
Raise ValueError
saumya-saran Sep 18, 2024
386ac90
Line too long
saumya-saran Sep 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion vllm/sampling_params.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -273,9 +273,14 @@ def __post_init__(self) -> None:
self._all_stop_token_ids = set(self.stop_token_ids)

def _verify_args(self) -> None:
if not isinstance(self.n, int):
raise ValueError(f"n must be an int, but is of "
f"type {type(self.n)}")
if self.n < 1:
raise ValueError(f"n must be at least 1, got {self.n}.")
assert isinstance(self.best_of, int)
if not isinstance(self.best_of, int):
raise ValueError(f'best_of must be an int, but is of '
f'type {type(self.best_of)}')
if self.best_of < self.n:
raise ValueError(f"best_of must be greater than or equal to n, "
f"got n={self.n} and best_of={self.best_of}.")
Expand Down
Loading