Skip to content

Conversation

dtrifiro
Copy link
Contributor

@dtrifiro dtrifiro commented Sep 26, 2024

publish.yml currently fails, see #8771 (comment) for context

Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@dtrifiro
Copy link
Contributor Author

@youkaichao

@youkaichao
Copy link
Member

how about just use pip install -r requirements-build.txt ?

@dtrifiro
Copy link
Contributor Author

@youkaichao good call. Moved to #8900

@dtrifiro dtrifiro closed this Sep 27, 2024
@dtrifiro dtrifiro deleted the fix-release-ci branch September 27, 2024 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants