Skip to content

[Bugfix] Deprecate registration of custom configs to huggingface #9083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 5, 2024
Merged

[Bugfix] Deprecate registration of custom configs to huggingface #9083

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
980b00b
not register custom configs to hugggingface
heheda12345 Oct 4, 2024
3933194
make formater happy
heheda12345 Oct 4, 2024
1af2d73
update unit tests
heheda12345 Oct 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion tests/models/decoder_only/vision_language/test_internvl.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,8 @@ def __init__(self, hf_runner: HfRunner):
self.tokenizer = hf_runner.tokenizer
self.dtype = hf_runner.model.dtype

self.config = AutoConfig.from_pretrained(hf_runner.model_name)
self.config = AutoConfig.from_pretrained(hf_runner.model_name,
trust_remote_code=True)
self.vision_config = self.config.vision_config
self.use_thumbnail = self.config.use_thumbnail
self.min_num = self.config.min_dynamic_patch
Expand Down
7 changes: 0 additions & 7 deletions tests/models/encoder_decoder/vision_language/test_mllama.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,11 +195,6 @@ def _run_test(
def process(hf_inputs: BatchEncoding):
return hf_inputs

from transformers.models.mllama import MllamaConfig as MllamaConfigHf

# use transformer's MllamaConfig for hf_runner
# and vllm's MllamaConfig for vllm_runner
AutoConfig.register("mllama", MllamaConfigHf, exist_ok=True)
with hf_runner(model,
dtype=dtype,
model_kwargs={"device_map": "auto"},
Expand All @@ -213,8 +208,6 @@ def process(hf_inputs: BatchEncoding):
for prompts, images in inputs
]

from vllm.transformers_utils.configs.mllama import MllamaConfig
AutoConfig.register("mllama", MllamaConfig, exist_ok=True)
for hf_outputs, vllm_outputs in zip(hf_outputs_per_image,
vllm_outputs_per_image):
check_logprobs_close(
Expand Down
8 changes: 0 additions & 8 deletions vllm/transformers_utils/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
import contextlib
import enum
import json
from pathlib import Path
Expand Down Expand Up @@ -61,13 +60,6 @@
**_CONFIG_REGISTRY_OVERRIDE_HF
}

for name, cls in _CONFIG_REGISTRY.items():
with contextlib.suppress(ValueError):
if name in _CONFIG_REGISTRY_OVERRIDE_HF:
AutoConfig.register(name, cls, exist_ok=True)
else:
AutoConfig.register(name, cls)


class ConfigFormat(str, enum.Enum):
AUTO = "auto"
Expand Down
Loading