[WIP] Use dependency injection for extra pluginmanager #1818
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make the stardard plugin manager myvolumio agnostic, by using dependency injection to pass in the right "extra pluginmanager" when it instanciated. This will allow for passing alternative pluginmanagers for specific OEMs as well as making the code more testable, which will become useful in the future.
|
@piffio is it still relevant? can you check against regression before merging? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is still WIP, do not merge yet
Make the stardard plugin manager myvolumio agnostic, by using dependency
injection to pass in the right "extra pluginmanager" when it
instanciated.
This will allow for passing alternative pluginmanagers for specific OEMs
as well as making the code more testable, which will become useful in
the future.