Support to open pull request to another repo #70
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @mszhanyi that's an interesting idea! I should be able to take a look over the weekend. |
vsoch
reviewed
Apr 22, 2021
vsoch
reviewed
Apr 25, 2021
| @@ -71,6 +73,8 @@ an issue or PR, they are ignored otherwise. | |||
| The `GITHUB_TOKEN` secret is required to interact and authenticate with the GitHub API to open | |||
| the pull request. The example is [deployed here](https://github.com/vsoch/pull-request-action-example) with an example opened (and merged) [pull request here](https://github.com/vsoch/pull-request-action-example/pull/1) if needed. | |||
There was a problem hiding this comment.
@mszhanyi I'm wondering if there is a way to make this less complicated. E.g., the user still could use the GITHUB_TOKEN variable defined in secrets to be a PAT? Are there cases when both would be wanted so this wouldn't work?
And the same question for GITHUB_REPOSITORY. Is there a way to not have two variables for the "same" thing?
There was a problem hiding this comment.
According to https://docs.github.com/en/actions/reference/environment-variables#naming-conventions-for-environment-variables , It looks it's not necessary to define GITHUB_XXX.
update with comments Co-authored-by: Vanessasaurus <[email protected]>
vsoch
approved these changes
Apr 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I need to submit PRs to another PR but GITHUB_REPOSITORY always refers to current repo.
So I make this little change, maybe others need this option as well