-
Notifications
You must be signed in to change notification settings - Fork 4.4k
Add sourcemap option to postCSS-loader options #1039
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the correct syntax I think.
Maybe change the var
in const
?
The warning from postcss-loader is still there. Setting cssSourceMap
to true
in dev config did the trick but I don't think we want to set this one to true by default ...
I looked around a little bit and this warning is common for people using vue-loader
.
See the comment from Evan at the bottom of this thread.
There's no need to use postcss-loader with vue-loader. Just use vue-loader' own postcss option.
But maybe it was added to process css
files outside of *.vue
files ?
Hm, thanks for testing it out - vuejs/vue-loader#937 might also be of interest, but:
Seems some digging will be necessary to make this work. A job for the weekend. |
@Tirke I found the issue - it was another mistake in the original PR, a strict That resulted in postss-loader being included where it shouldn't. The fix I just pushed should solve this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You may have forgotten to use const
instead of var
for the postcssLoader
variable.
Otherwise all good for me, no more warnings, working as expected.
Good eye, but that's cosmetics. Will add this later. |
* Add sourcemap option to postCSS-loader options * Update utils.js * fix condition, should als fail on `undefined`
* Add sourcemap option to postCSS-loader options * Update utils.js * fix condition, should als fail on `undefined`
No description provided.