Skip to content

Fix hot reload, if install template with Yarn #734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

TuxBoy
Copy link

@TuxBoy TuxBoy commented Jun 4, 2017

Hi,
The hot reload does not work if we install the template via yarn, when I add the last piece of code it works, after why exactly that bug with yarn, I do not know.

Thanks

@LinusBorg
Copy link
Contributor

LinusBorg commented Oct 3, 2017

This is likely not related to yarn, but some other environment you use (dropbox /docker / vagrant ...) which interfers with webpacks default way of watching files for changes.

However, polling is not a very performant way to watch files, so we should make this optional. I just submitted a PR for that (#946 ), before finding yours.

I hope it's ok if I close yours in favour of mine, which adds a more flexible config option.

Greets, Thorsten.

@LinusBorg LinusBorg closed this Oct 3, 2017
@TuxBoy
Copy link
Author

TuxBoy commented Oct 4, 2017

Ok, thanks so much for your reply.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants