Make changing port from cli possible. #923
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
posva
reviewed
Sep 18, 2017
| ``` | ||
|
|
||
| If port 8080 is already in use on your machine you must change the port number in `/config/index.js`. Otherwise `npm run dev` will fail. |
There was a problem hiding this comment.
As this is still true, can you leave something similar like:
You can change the port at `config/index.js` as well if you don't want to pass the option every time
|
@posva updated. |
posva
reviewed
Sep 20, 2017
| ``` | ||
|
|
||
| If port 8080 is already in use on your machine you must change the port number in `/config/index.js`. Otherwise `npm run dev` will fail. | ||
| You can change the port at `config/index.js` as well. |
There was a problem hiding this comment.
if you don't want to pass the option every time
|
Actually, this is not necessary once #913 is merged |
|
Well, port detection is more intelligent, but my patch is very light without extra dependency, it provides chance to specify a port anytime . |
|
Hi @UncleBill Thanks for your PR. However, I just merged port detection, also you can use the PORT env variable as well as the config. That should provide more than enough options to configure this. So I have to close this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Can pass optional argument to
npm run dev. like:npm run dev -- --port 6060run at port 6060.