Redirect to index in webpack-dev-server if assetsPublicPath is set (close #915) #980
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When assetsPublicPath is set, index.html and other files are server from this path and not from the root. Starting webpack-dev-serve in this case is showing a blank page on the root url. This change adds a redirection from the root url to assetsPublicPath for convenience.
LinusBorg
reviewed
Oct 13, 2017
template/build/webpack.dev.conf.js
Outdated
| }, | ||
| before: function(app) { | ||
| // Redirect to index.html in assetsPublicPath if path is not set to root | ||
| if (config.dev.assetsPublicPath && config.dev.assetsPublicPath != '/') { |
There was a problem hiding this comment.
- I think
!==is better, stylistically. - Just thinking: Could this break anything for a relative path ('./')?
There was a problem hiding this comment.
this (comment above this one for the same line) has to be tested before merge.
LinusBorg
suggested changes
Oct 16, 2017
template/build/webpack.dev.conf.js
Outdated
| }, | ||
| before: function(app) { | ||
| // Redirect to index.html in assetsPublicPath if path is not set to root | ||
| if (config.dev.assetsPublicPath && config.dev.assetsPublicPath != '/') { |
There was a problem hiding this comment.
this (comment above this one for the same line) has to be tested before merge.
LinusBorg
changed the base branch from
feature/webpack-dev-server(#964)
to
develop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When assetsPublicPath is set, index.html and other files are server from this path
and not from the root. Starting webpack-dev-serve in this case is showing a blank
page on the root url. This change adds a redirection from the root url to
assetsPublicPath for convenience.