refactor(reactivity): extract isRef to shared #11202
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ferferga
force-pushed
the
extract-is-ref
branch
2 times, most recently
from
ad8f7ca to
391b91a
Compare
|
The core logic of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the merge of #7306, I noticed that isRef is redeclared in shared because shared can't have dependencies (didn't thought about that during the reviewing, sorry!). However, reactivity has shared as a dependency.
I think it makes more sense to have a single implementation in shared (and re-export from reactivity) for better tree-shaking and maintainability