Skip to content

fix(vdom): add null check in fragment removal Add null check for 'cu… #13737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(vdom): add null check in fragment removal Add null check for 'cu… #13737

wants to merge 1 commit into from

Conversation

Litor
Copy link

@Litor Litor commented Aug 5, 2025 •
edited
Loading

fix(vdom): add null check in fragment removal

Add null check for 'cur' in removeFragment function to prevent potential
null reference errors when traversing DOM nodes. The while loop now
verifies 'cur' exists before comparing with 'end'.

This makes the fragment removal more robust when dealing with edge cases.

Summary by CodeRabbit

  • Bug Fixes
    • Improved stability when removing elements by preventing potential errors that could occur if an element is unexpectedly missing.
image no legacy plugin is ok; add legacy plugin throw error

@Litor
fix(vdom): add null check in fragment removal Add null check for 'cur…
7623d08 
…' in removeFragment function to prevent potential null reference errors when traversing DOM nodes. The while loop now verifies 'cur' exists before comparing with 'end'. This makes the fragment removal more robust when dealing with edge cases.
@coderabbitai coderabbitai
Copy link

coderabbitai bot commented Aug 5, 2025 •
edited
Loading

Walkthrough

The update adjusts the loop condition in the removeFragment function within the renderer module. The loop now includes a null check to prevent execution if the current node is null or undefined, thereby avoiding potential runtime errors during fragment removal.

Changes

Cohort / File(s) Change Summary
Renderer Fragment Removal Logic
packages/runtime-core/src/renderer.ts		 Modified the loop condition in removeFragment to include a null check, preventing errors if the current node is null or undefined.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

In the garden of code, a fragment once strayed,
A null little bunny made bugs cascade.
Now with a check, the loop hops true,
No more surprises—just clean code for you!
🐇✨

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c875019 and 7623d08.

📒 Files selected for processing (1)
  • packages/runtime-core/src/renderer.ts (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: Redirect rules
  • GitHub Check: Header rules
  • GitHub Check: Pages changed
🔇 Additional comments (1)
packages/runtime-core/src/renderer.ts (1)

2263-2263: LGTM! Excellent defensive programming improvement.

The null check prevents potential runtime errors when hostNextSibling(cur) returns null during DOM traversal. This makes the fragment removal process more robust against edge cases where DOM nodes might be missing or the structure is incomplete.

✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@Litor
Copy link
Author

Litor commented Aug 5, 2025 •
edited
Loading

image image image

when run to here -> next = hostNextSibling(cur); node.nextSibling is undefined, next loop throw error

image

@edison1105
Copy link
Member

Please provide a minimal reproducible demo so we can investigate the actual issue.

@Litor
Copy link
Author

Litor commented Aug 5, 2025

image remove this code is ok too @edison1105

@edison1105 edison1105 added the need more info Further information is requested label Aug 5, 2025
@Litor
Copy link
Author

Litor commented Aug 6, 2025 •
edited
Loading

image

I understand the reason now. It's because the generated code contains this location.protocol != 'file:' check, which causes both the type='module' and nomodule scripts in index.html to execute. I happen to be using the file:// protocol. Why was this check added here? Is there a config option to remove this check?" @edison1105

@edison1105
Copy link
Member

edison1105 commented Aug 6, 2025 •
edited
Loading

image I understand the reason now. It's because the generated code contains this location.protocol != 'file:' check, which causes both the type='module' and nomodule scripts in index.html to execute. I happen to be using the file:// protocol. Why was this check added here? Is there a config option to remove this check?" @edison1105

This code appears to be plugin-generated. However, per your diagnostic findings, the issue originates from the plugin implementation rather than vuejs/core.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
need more info Further information is requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Litor @edison1105