types(reactivity): disallow using functions with arguments as a computed getter (fix #5692)

packages/reactivity/src/computed.ts

@@ -15,14 +15,20 @@ export interface WritableComputedRef<T> extends Ref<T> {
   readonly effect: ReactiveEffect<T>
 }
 
-export type ComputedGetter<T> = (...args: any[]) => T
+export type ComputedGetter<T> = () => T
+export type ComputedGetterWithInstance<T> = (...args: any[]) => T
 export type ComputedSetter<T> = (v: T) => void
 
 export interface WritableComputedOptions<T> {
   get: ComputedGetter<T>
   set: ComputedSetter<T>
 }
 
+export interface WritableComputedOptionsWithInstance<T> {
+  get: ComputedGetterWithInstance<T>
+  set: ComputedSetter<T>
+}
+
 export class ComputedRefImpl<T> {
   public dep?: Dep = undefined
 

packages/reactivity/src/index.ts

@@ -38,7 +38,9 @@ export {
   ComputedRef,
   WritableComputedRef,
   WritableComputedOptions,
+  WritableComputedOptionsWithInstance,
   ComputedGetter,
+  ComputedGetterWithInstance,
   ComputedSetter
 } from './computed'
 export { deferredComputed } from './deferredComputed'

packages/runtime-core/src/componentOptions.ts

@@ -46,8 +46,8 @@ import {
 } from './apiLifecycle'
 import {
   reactive,
-  ComputedGetter,
-  WritableComputedOptions
+  ComputedGetterWithInstance,
+  WritableComputedOptionsWithInstance
 } from '@vue/reactivity'
 import {
   ComponentObjectPropsOptions,
@@ -360,7 +360,7 @@ export type ComponentOptionsMixin = ComponentOptionsBase<
 
 export type ComputedOptions = Record<
   string,
-  ComputedGetter<any> | WritableComputedOptions<any>
+  ComputedGetterWithInstance<any> | WritableComputedOptionsWithInstance<any>
 >
 
 export interface MethodOptions {