style: prefer import type
#8565
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sxzz
reviewed
Jun 13, 2023
I added |
Justineo
approved these changes
Jun 14, 2023
❌ Deploy Preview for vue-sfc-playground failed.
|
❌ Deploy Preview for vue-next-template-explorer failed.
|
|
cc @sxzz 👀 |
|
Conflicted. Could you please rebase your branch? |
Hi, I have resolved the conflict on the branch |
sxzz
approved these changes
Aug 14, 2023
sxzz
force-pushed
the
chore-import-type
branch
2 times, most recently
from
b457c75 to
1285b32
Compare
sxzz
force-pushed
the
chore-import-type
branch
from
1285b32 to
1561338
Compare
Size ReportBundles
Usages
|
sxzz
force-pushed
the
chore-import-type
branch
from
1561338 to
26b7136
Compare
|
It will create lots of conflicts for other PRs. We need to wait for a time to merge/clean up the PR. Let's put that on hold for now. 😇 |
|
Yes, this PR will cause a large conflict, we should put it to the last merge. |
This was referenced Sep 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we intend to use a value solely as a type, we should import the type using
import typeinstead of importing the value. I have only handled cases where values are used as types, perhaps we should set"importsNotUsedAsValues": "error"to prevent such occurrences?