Skip to content

style: prefer node: protocol #8584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 19, 2023
Merged

style: prefer node: protocol #8584

merged 2 commits into from
Dec 19, 2023

Conversation

Alfred-Skyblue
Copy link
Member

@Alfred-Skyblue Alfred-Skyblue commented Jun 15, 2023 •
edited
Loading

Use import xxx from 'node:xxx' to import node built-in modules.

@netlify
Copy link

netlify bot commented Jun 15, 2023 •
edited
Loading

❌ Deploy Preview for vue-sfc-playground failed.

Name Link
🔨 Latest commit b8a9582
🔍 Latest deploy log https://app.netlify.com/sites/vue-sfc-playground/deploys/64db6bf8d5796b0008842d70

sxzz
sxzz reviewed Aug 15, 2023
View reviewed changes
Copy link
Member

@sxzz sxzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can add an ESLint rule as well

https://github.com/vitejs/vite/blob/63a44511133276f903e54d4dde4296d5d5963298/.eslintrc.cjs#L92-L95

@Alfred-Skyblue Alfred-Skyblue requested a review from sxzz August 15, 2023 12:55
@Alfred-Skyblue Alfred-Skyblue force-pushed the chore-node branch 2 times, most recently from 114a8e7 to b14ed6c Compare August 15, 2023 13:58
@Alfred-Skyblue
Copy link
Member Author

I have installed the eslint-plugin-import plugin within the project. However, since compiler-sfc.esm-browser.js will be running in a browser environment, using the node:xxx import syntax is not viable. Consequently, I have overridden the rules for the compiler-sfc directory.

@sxzz sxzz mentioned this pull request Aug 21, 2023
Closed
@sxzz sxzz added the ready for review This PR requires more reviews label Aug 21, 2023
@github-actions
Copy link

github-actions bot commented Aug 21, 2023 •
edited
Loading

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 85.8 kB 32.6 kB 29.5 kB
vue.global.prod.js 132 kB 49.3 kB 44.3 kB

Usages

Name Size Gzip Brotli
createApp 47.9 kB 18.8 kB 17.2 kB
createSSRApp 50.6 kB 19.9 kB 18.2 kB
defineCustomElement 50.3 kB 19.6 kB 17.9 kB
overall 61.2 kB 23.7 kB 21.6 kB

@sxzz sxzz changed the title chore: update the syntax for importing built-in modules in Node style: prefer node: protocol Sep 7, 2023
@sxzz sxzz changed the base branch from main to chore/style September 7, 2023 13:48
@sxzz sxzz mentioned this pull request Sep 7, 2023
Merged
@sxzz sxzz force-pushed the chore/style branch 3 times, most recently from b96fea8 to de5f795 Compare December 19, 2023 09:18
@sxzz sxzz merged commit 00c6f85 into vuejs:chore/style Dec 19, 2023
@Alfred-Skyblue Alfred-Skyblue deleted the chore-node branch December 19, 2023 13:28
sxzz added a commit that referenced this pull request Dec 19, 2023
@Alfred-Skyblue @sxzz
style: prefer node: protocol (#8584)
dcb0e1f 
Co-authored-by: 丶远方 <[email protected]>
Co-authored-by: 三咲智子 Kevin Deng <[email protected]>
sxzz added a commit that referenced this pull request Dec 19, 2023
@Alfred-Skyblue @sxzz
style: prefer node: protocol (#8584)
5755b69 
Co-authored-by: 丶远方 <[email protected]>
Co-authored-by: 三咲智子 Kevin Deng <[email protected]>
sxzz added a commit that referenced this pull request Dec 19, 2023
@Alfred-Skyblue @sxzz
style: prefer node: protocol (#8584)
e980458 
Co-authored-by: 丶远方 <[email protected]>
Co-authored-by: 三咲智子 Kevin Deng <[email protected]>
sxzz added a commit that referenced this pull request Dec 20, 2023
@Alfred-Skyblue @sxzz
style: prefer node: protocol (#8584)
76f330b 
Co-authored-by: 丶远方 <[email protected]>
Co-authored-by: 三咲智子 Kevin Deng <[email protected]>
sxzz added a commit that referenced this pull request Dec 26, 2023
@Alfred-Skyblue @sxzz
style: prefer node: protocol (#8584)
0b32994 
Co-authored-by: 丶远方 <[email protected]>
Co-authored-by: 三咲智子 Kevin Deng <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sxzz sxzz Awaiting requested review from sxzz

Assignees
No one assigned
Labels
ready for review This PR requires more reviews
Projects
Issue / PR Management
Status: Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Alfred-Skyblue @sxzz