fix(vue2): handling un-namespaced vuex module #1442
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Akryum
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found Vue Devtools 6 fails to handle Vuex modules without namespace (
namespaced = false).The
gettersof that kind of modules seems to be got frommodule.context.getters.add details...
I fixed the part of
formatStoreForInspectorStateand it is called from following part.https://github.com/vuejs/vue-devtools/blob/d5e0579b35a7c93869ddb839e3863219202ab0ec/packages/app-backend-vue2/src/plugin.ts#L101-L114
This means
gettersargument offormatStoreForInspectorStateisstore._makeLocalGettersCache, butstore._makeLocalGettersCachedoesn't look includesrootmodules' ones and un -namespaced moduels' ones but only includes namespaced modules' ones.So before my fixing,
TypeError: Cannot convert undefined or null to objecterror occurs at line 350 since getters of un-namespaced modules are not contained bygetters[path].https://github.com/vuejs/vue-devtools/blob/d5e0579b35a7c93869ddb839e3863219202ab0ec/packages/app-backend-vue2/src/plugin.ts#L348-L351