-
Notifications
You must be signed in to change notification settings - Fork 4.7k
docs: Russian translation #1042
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great.
I can't review the translation itself as I don't know Russian but I've tried to provide general feedback.
Could you add https://v3.ru.vuejs.org/
to vuejs/docs-next/src/.vuepress/components/guide/contributing/translations-data.js
as part of this PR? The translation repo is already listed, it just needs the deployment URL.
On the front page, https://v3.ru.vuejs.org/, the green video button doesn't work. Clicking that button just navigates to https://v3.ru.vuejs.org/ru/ instead.
There are some links in the main navigation that link to the page https://v3.ru.vuejs.org/support-vuejs/. I believe they need a /ru
adding to their path.
The search box is searching the English docs.
From https://v3.ru.vuejs.org/ru/cookbook/editable-svg-icons.html:
I believe they're supposed to be bullet points rather than a quote.
Could you update the repo URL on GitHub?
For the root README.md
(shown here, not the one in src
), could you update it with content relevant to that repo? That's the entry point for new contributors, so ideally it should confirm that they're in the right place. Explaining how you manage pulling in upstream changes might be worth a mention too.
Here are some examples from other translations if you're looking for inspiration:
- https://github.com/vuejs-id/docs-next/#readme
- https://github.com/vuejs/docs-next-zh-cn/#readme
The spacing problems you've observed with some headings in the migration guide are a problem in the English docs too. I think it's caused by the custom CSS that's used to insert the badges rather than VuePress itself. More investigation needed on our end.
The clash between the PWA popup and code blocks is being tracked here: #865
I wasn't aware of vuepress-plugin-check-md
. I check the internal links in the docs using my own tool, https://github.com/skirtles-code/vue-docs-link-checker. I concur that you don't have any broken links.
Thanks for review, @skirtles-code !
Added
Changed url to
Fixed
Fixed
Updated
Updated |
I think the broken search box is quite important. It currently searches the hidden copy of the English docs. Clicking on a search result opens an English page without a sidebar. I don't know how difficult it is to fix it. If it can't be configured to search the right locale then maybe just turn it off altogether for now? |
@skirtles-code I don't know how to fix search. Turn off searchbox for now |
Finally! :)
Some points:
It's convenient for me to save English localization files to make it easier to merge from upstream without conficts and later compare files side-by-side. That why russian locale stored in
/ru/
folder and not as default/
Links for page now contain doubled
ru
, for examplehttps://v3.ru.vuejs.org/ru/guide/introduction.html
. That's because vuepress didn't offer a way to pre-set default locale. Rewrite russian locale files as default locale is not useful (see above)Root README.md file for english locale duplicated from russian. I don't know how to show /ru/README.md file if I need to show russian locale as default one.
Also had to duplicate translation here, because vuepress at start page show /README.md for english locale and not /ru/README.md for russian. And update popup also showed in english.
Vuepress show some pages with big empty space, but some don't (also codeblocks in headings don't have space around). See screenshots:
The name of the language for the code block overlaps with the content update message
Also check with
vuepress-plugin-check-md
and some hashes showed as broken, but they exist and links works ok. Maybe also bug in plugin.Don't know where to start digging about this problems, but I don't have enough energy and time for that and if someone could help I will be glad for that.