Skip to content

Conversation

lovetingyuan
Copy link
Contributor

Description of Problem

Wrong option field in async component migration page: https://v3.vuejs.org/guide/migration/async-components.html#_3-x-syntax.

Proposed Solution

change the wrong option name to correct ones.

Additional Information

image

Copy link
Contributor

@skirtles-code skirtles-code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

I'm unclear why that example is needed. It doesn't really add anything that isn't included in the previous example. With a small tweak to the wording of the sentence about the loader option, I think we could remove the example altogether.

@NataliaTepluhina NataliaTepluhina merged commit 9d48e28 into vuejs:master Dec 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants