Skip to content

New: Add vue/require-shorthand-boolean-prop rule #1102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

inker
Copy link

@inker inker commented Apr 19, 2020

This PR adds the vue/require-shorthand-boolean-prop rule.

ref #775

@ota-meshi
Copy link
Member

ota-meshi commented May 9, 2020

Thank you for this PR.

Due to the props definition of the used component, :isValid="true" and isValid are not equivalent.
I don't think this rule can report errors correctly.

What do you think?

@inker
Copy link
Author

inker commented May 19, 2020

Due to the props definition of the used component, :isValid="true" and isValid are not equivalent.

I see what you mean. Currently, it only works for boolean props. Will investigate if it's possible to do prop type checking.

@ota-meshi
Copy link
Member

I don't think there is a good way to do type checking right now, so I'll close this PR. If you know a good way, please let me know.

@ota-meshi ota-meshi closed this Jun 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants