Skip to content

Update: upgrade vue-eslint-parser (fixes #36, fixes #56, fixes #96) #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 1, 2017

Conversation

mysticatea
Copy link
Member

Thank you for waiting!
I have almost done to rewrite vue-eslint-parser. ✨

This PR has breaking changes in internal APIs, but the rule behaviors are keeping as is, so I think fine as semver-minor.

Though I have many tests (12499 passing 😄) to parse HTML, I guess some bugs remain.


for (const error of node.errors) {
if (error.code && !options[error.code]) {
continue
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

!options[error.code] this is not covered in tests, you should consider adding test with errors but disable them.

Copy link
Contributor

@armano2 armano2 Jul 30, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also you are missing

{
      filename: 'test.vue',
      code: `<template v-for="x of list">
        <slot name="item" />
      </template>`
    }

@mysticatea
Copy link
Member Author

@armano2 Thank you! I added more tests.

@mysticatea mysticatea merged commit 49b40d6 into master Aug 1, 2017
@mysticatea mysticatea deleted the rewrite-parser branch August 1, 2017 08:43
filipalacerda pushed a commit to filipalacerda/eslint-plugin-vue that referenced this pull request Aug 5, 2017
* master:
  Add rule `vue/require-valid-default-prop`. (vuejs#119)
  3.10.0
  Update readme to 3.10.0
  Chore: remove package-lock.json (vuejs#128)
  Fix: parserService must exist always (fixes vuejs#125) (vuejs#127)
  Add rule `require-render-return`. (vuejs#114)
  3.9.0
  Update package-lock
  Update: options for `no-duplicate-attributes` (fixes vuejs#112)(vuejs#113)
  New: add rule `attribute-hyphenation`. (fixes vuejs#92)(vuejs#95)
  Add namespace check of svg & mathML instead of tag names (vuejs#120)
  ⚠️ Add support for deprecated state in update-rules ⚠️ (vuejs#121)
  Add rules: `no-dupe-keys` and `no-reserved-keys`. (vuejs#88)
  Chore: Improve tests for name-property-casing & improve documentation (vuejs#115)
  New: add `require-prop-types` rule (fixes vuejs#19)(vuejs#85)
  Update: upgrade vue-eslint-parser (fixes vuejs#36, fixes vuejs#56, fixes vuejs#96) (vuejs#116)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants