-
-
Notifications
You must be signed in to change notification settings - Fork 681
Update: upgrade vue-eslint-parser (fixes #36, fixes #56, fixes #96) #116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
||
for (const error of node.errors) { | ||
if (error.code && !options[error.code]) { | ||
continue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
!options[error.code]
this is not covered in tests, you should consider adding test with errors but disable them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also you are missing
{
filename: 'test.vue',
code: `<template v-for="x of list">
<slot name="item" />
</template>`
}
@armano2 Thank you! I added more tests. |
* master: Add rule `vue/require-valid-default-prop`. (vuejs#119) 3.10.0 Update readme to 3.10.0 Chore: remove package-lock.json (vuejs#128) Fix: parserService must exist always (fixes vuejs#125) (vuejs#127) Add rule `require-render-return`. (vuejs#114) 3.9.0 Update package-lock Update: options for `no-duplicate-attributes` (fixes vuejs#112)(vuejs#113) New: add rule `attribute-hyphenation`. (fixes vuejs#92)(vuejs#95) Add namespace check of svg & mathML instead of tag names (vuejs#120)⚠️ Add support for deprecated state in update-rules⚠️ (vuejs#121) Add rules: `no-dupe-keys` and `no-reserved-keys`. (vuejs#88) Chore: Improve tests for name-property-casing & improve documentation (vuejs#115) New: add `require-prop-types` rule (fixes vuejs#19)(vuejs#85) Update: upgrade vue-eslint-parser (fixes vuejs#36, fixes vuejs#56, fixes vuejs#96) (vuejs#116)
Thank you for waiting!
I have almost done to rewrite
vue-eslint-parser
. ✨no-parsing-errors
rule. It allows us to catch syntax errors of HTML. Those are opt-in for now since enhancement which increases errors is a breaking change.<template>
a bit. Notable changes are below:element.name
property now. It waselement.startTag.id.name
before.element.namespace
. The value of namespaces are defined in there.VOnExpression
node is added in order to handle vue/no-parsing-error: comma-separated methods #96 correctly.This PR has breaking changes in internal APIs, but the rule behaviors are keeping as is, so I think fine as semver-minor.