Skip to content

Conversation

luizotcarvalho
Copy link
Contributor

@luizotcarvalho luizotcarvalho commented Apr 4, 2024

Changes are aimed at improving Pinia support.

Following Pinia methods will be checked: mapGetters, mapState, mapWritableState and mapActions, when no-unused-properties will be enabled.

Its not possible to support mapStores easily because de result variable is the store id + Store (See more) and would fail always.

Fixes #1675.

@FloEdelmann FloEdelmann changed the title Add support to pinia (#1675) Support Pinia methods in vue/no-unused-properties Apr 4, 2024
Copy link
Member

@FloEdelmann FloEdelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh wow, that was fast! And the code looks good to me. Thanks 🙂

@FloEdelmann FloEdelmann requested a review from ota-meshi April 4, 2024 12:40
Copy link
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Vuex and Pinia support

3 participants