docs: add explicit import #1211
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds undocumented import statement to code snippet to make it clear how to properly import the router.
|
This is actually intentional. There is an open issue about it |
|
I am guessing you are referring to this cryptic issue from 7 months ago. I fail to see how that issue detailing a full rewrite of the docs prevents us from having the short-term benefit of mentioning anywhere how to import the router. As I see it, you can do both, and it prevents people from bumping in yet another roadblock while trying out this version of the router while you improve the docs long-term. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The syntax used to be
import VueRouter from 'vue-router', but this does not seem to work anymore. With some experimentation this seems to be the required syntax, but I can't find the documentation for that anywhere. With this change it will be clear from the code snippet how to properly import the router.