Skip to content

docs: add description of key property when using transition in reused component #854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

docs: add description of key property when using transition in reused component #854

wants to merge 1 commit into from

Conversation

shadowings-zy
Copy link

Close #803

@posva
Copy link
Member

posva commented Mar 29, 2021

Thanks! The idea is to show when adding a key can help. Most of the time people shouldn't add a key

@shadowings-zy shadowings-zy changed the title docs: add description of key property when using transition in router docs: add description of key property when using transition in reused component Apr 18, 2021
@shadowings-zy
Copy link
Author

@posva hi, I update the PR. And I add the description "Trigger Transition In Reused Component"

@posva posva closed this in a11b04f Jun 14, 2021
@posva
Copy link
Member

posva commented Jun 14, 2021

Thank you for the PR but I went with a different version of this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@the-adonis the-adonis the-adonis approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Route with same component not triggering transition
3 participants
@shadowings-zy @posva @the-adonis