fix: findAll root nodes when using render function #1227
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cexbrayat
approved these changes
Jan 10, 2022
|
Thanks @freakzlike for the PR! Does it also fix #1173 ? Would you mind adding a test in the PR to check? cc @xanf on his, as he may have started to work on that, and knows this code better than me. |
|
@cexbrayat I ran the unit test from #1172 with this changes but it was the same result as before. |
lmiller1990
approved these changes
Jan 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will fix #1201.
I just used the same logic of
findforfindAlland unified this into one method. So same logic forfindandfindAll(except ref selector forfind)