Skip to content

feat: added typehint to the trigger method #551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
May 11, 2021
Merged

feat: added typehint to the trigger method #551

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
aad4ebe
feat: added typehint to the trigger method
nandi95 Apr 27, 2021
9db3431
chore: fixed linting issues
nandi95 Apr 27, 2021
2d94599
fix: updated to use correct type cast
nandi95 Apr 27, 2021
9bba382
feat: Added typings
nandi95 May 1, 2021
5a5bc0b
feat: Added overrides
nandi95 May 5, 2021
8d5b599
feat: Updated baseWrapper trigger return value
nandi95 May 5, 2021
22559bd
feat: moved trigger method body to the baseWrapper
nandi95 May 5, 2021
c66c77d
feat: reverted non-baseWrapper triggers
nandi95 May 11, 2021
c792818
feat: reverted unnecessary changes
nandi95 May 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@
"@vue/compiler-sfc": "3.0.11",
"babel-jest": "^26.6.3",
"babel-preset-jest": "^26.6.2",
"dom-event-types": "^1.0.0",
"husky": "^6.0.0",
"jest": "25.5.4",
"jsdom": "^16.5.3",
Expand Down
3 changes: 2 additions & 1 deletion src/baseWrapper.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ import { textContent } from './utils'
import { createDOMEvent } from './createDomEvent'
import type { TriggerOptions } from './createDomEvent'
import { nextTick } from 'vue'
import { DomEventName } from './constants/dom-event-types'

export default class BaseWrapper<ElementType extends Element> {
private readonly wrapperElement: ElementType
Expand Down Expand Up @@ -44,7 +45,7 @@ export default class BaseWrapper<ElementType extends Element> {
return true
}

async trigger(eventString: string, options?: TriggerOptions) {
async trigger(eventString: DomEventName | string, options?: TriggerOptions) {
if (options && options['target']) {
throw Error(
`[vue-test-utils]: you cannot set the target value of an event. See the notes section ` +
Expand Down
Loading