Skip to content

Vue Mastery Free Weekend announcement #1997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 19 commits into from
Feb 15, 2019
Merged

Vue Mastery Free Weekend announcement #1997

merged 19 commits into from
Feb 15, 2019
+322 −1

Conversation

pieer
Copy link
Contributor

@pieer pieer commented Feb 13, 2019

In preparation for Vue Mastery Free Weekend announcement on Friday here is a pull request that:

  • Add a banner at the top of the site vue.org
  • Redirect user to vue mastery in a new tab on click
  • The banner disappear after scroll to only show the static nav and the content
  • Let the user remove the banner
  • The banner won’t show up again after the user clicked on the close button (saved in local storage)
  • Keep the usual mobile behaviour with static header
  • Tested on Chrome, Safari, and firefox

pieer added 18 commits February 13, 2019 12:31
chrisvfritz
chrisvfritz suggested changes Feb 15, 2019
View reviewed changes
Copy link
Contributor

@chrisvfritz chrisvfritz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The X button doesn't appear to work currently - it opens the page rather than closing the banner for me in Chrome.

@yyx990803
Copy link
Member

LGTM. @chrisvfritz you can merge after you approve the change.

@chrisvfritz chrisvfritz merged commit 23224fd into vuejs:master Feb 15, 2019
NataliaTepluhina pushed a commit to NataliaTepluhina/vuejs.org that referenced this pull request Feb 25, 2019
@pieer @NataliaTepluhina
Revert "Vue Mastery Free Weekend announcement (vuejs#1997)"
b1598fe 
This reverts commit 23224fd.
NataliaTepluhina added a commit that referenced this pull request Feb 25, 2019
@NataliaTepluhina
Merge pull request #2031 from NataliaTepluhina/master

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
a01ab3f 
Revert "Vue Mastery Free Weekend announcement (#1997)"
phanan pushed a commit to phanan-forks/vuejs.org that referenced this pull request Mar 14, 2019
@pieer @phanan
Revert "Vue Mastery Free Weekend announcement (vuejs#1997)"
c3d14e6 
This reverts commit 23224fd.
phanan pushed a commit to phanan-forks/vuejs.org that referenced this pull request Mar 20, 2019
@pieer @phanan
Revert "Vue Mastery Free Weekend announcement (vuejs#1997)"
d94f378 
This reverts commit 23224fd.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yyx990803 yyx990803

+1 more reviewer

@chrisvfritz chrisvfritz

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pieer @yyx990803 @chrisvfritz