Add Function type to props #2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 Even though a Function or a Promise is just an Object (which is already there), being explicit here is a good idea. |
phanan
pushed a commit
to phanan-forks/vuejs.org
that referenced
this pull request
Mar 14, 2019
* Add Function type to props * add Promise contstructor prop type
phanan
pushed a commit
to phanan-forks/vuejs.org
that referenced
this pull request
Mar 20, 2019
* Add Function type to props * add Promise contstructor prop type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I realized we are not showing we can accept a Function which is a basic type in JS, it has misled people to believe they cannot use Functions.
However, I believe we can do better than just adding the line with callback: Function because we can also specify custom constructors or new ones like Promise
Looking forward to hear your feedback