Skip to content

Amend doc for new currency argument #287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 20, 2016
Merged

Amend doc for new currency argument #287

merged 1 commit into from
Apr 20, 2016

Conversation

phanan
Copy link
Member

@phanan phanan commented Apr 19, 2016

To follow up with vuejs/vue#2676.

@ludo237
Copy link
Contributor

ludo237 commented Apr 19, 2016

you should use the £ sign to keep it coherent with the previous example

@phanan
Copy link
Member Author

phanan commented Apr 19, 2016

Actually the sign should better demonstrate the purpose of the argument, as VND doesn't have any decimal places.

@yyx990803
Copy link
Member

I assume most users wouldn't know that symbol stands for VND, and they wouldn't know that VND uses no decimal places, so maybe add a bit of note on that ;)

@phanan
Copy link
Member Author

phanan commented Apr 20, 2016

Done.

@yyx990803 yyx990803 merged commit 5086cce into vuejs:master Apr 20, 2016
kazupon pushed a commit to kazupon/vuejs.org that referenced this pull request Oct 1, 2017
…Original) (vuejs#287)

* clarify naming in counter event components example, fixes vuejs#1051

* update timestamp
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants