Skip to content

Update Vue School banner copy #2948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Update Vue School banner copy #2948

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
61b9d38
Update Vue School banner copy
nicodevs Apr 28, 2022
2be46c9
Fix Vue School banner style
nicodevs Apr 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions themes/vue/layout/partials/vueschool_banner.ejs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,10 @@
<div class="vs-core">
<div class="vs-slogan">
<div class="vs-slogan-up">
Get up to <strong>40% off</strong> your Vue School Subscription
Extended for <strong>48 hours!</strong>
</div>
<div class="vs-slogan-down">
Time Limited Offer
Get up to 40% off your Vue School Subscription
</div>
</div>
<div class="vs-button">
Expand Down
5 changes: 2 additions & 3 deletions themes/vue/source/css/_vueschool.styl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,7 @@ body.has-vs-banner
@media (min-width: 680px)
min-height: $vs-banner-height-desktop
background-image: url(../images/banners/vs-fw-bg.svg)
background-position: top right -130px
@media (min-width: 900px)
background-position: top right
position: static
Expand Down Expand Up @@ -116,12 +117,10 @@ body.has-vs-banner
color: #FFF
font-size: 14px
font-weight: bold
width: 170px
@media (min-width: 680px)
font-size: 18px
width: 220px
@media (min-width: 1024px)
width: auto
@media (min-width: 1024px)
font-size: 24px
strong
color: #fdc722
Expand Down
4 changes: 3 additions & 1 deletion themes/vue/source/js/common.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,8 +285,10 @@
* Banner closing
*/
function initVueSchoolBanner () {
const now = new Date()
const end = new Date('2022-05-04T00:00:00+02:00')
const banner = document.getElementById('vs')
if (banner && !localStorage.getItem('VS_FW_BANNER_CLOSED_2')) {
if (banner && (now < end) && !localStorage.getItem('VS_FW_BANNER_CLOSED_2')) {
banner.classList.remove('vs-hidden')
document.body.classList.add('has-vs-banner')
document.getElementById('vs-close').addEventListener('click', function (e) {
Expand Down