Skip to content

Added GraphQL Loader #1502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Added GraphQL Loader #1502

wants to merge 1 commit into from

Conversation

BlackMix
Copy link
Contributor

@BlackMix BlackMix commented Jun 7, 2018

:)

// GraphQL Loader ------------------
webpackConfig.module
.rule('graphql')
.test(/\.graphql$/)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe .gql too

@Akryum
Copy link
Member

Akryum commented Jun 7, 2018

Hi, thanks for your PR! This isn't a feature that should be in the default configuration though because it's very specific. It should be in a 3rd-paty plugin instead (there is already one).

@Akryum Akryum closed this Jun 7, 2018
@egoist
Copy link
Collaborator

egoist commented Jun 7, 2018

hmm well there's even .pug support in the default config, I think it's ok to add .gql support since it's used a lot and doesn't introduce any dependencies.

@yyx990803 yyx990803 reopened this Jun 7, 2018
@yyx990803
Copy link
Member

Hmm yeah I don't think it should be in core.

@yyx990803 yyx990803 closed this Jun 7, 2018
@Akryum
Copy link
Member

Akryum commented Jun 7, 2018

@egoist pug support is included for the .vue files.
Also it does introduce a new dependency (graphql-tag).

@egoist
Copy link
Collaborator

egoist commented Jun 7, 2018

@Akryum I mean the dependency is not included in vue-cli 😄

@Akryum
Copy link
Member

Akryum commented Jun 7, 2018

But not in cli-service either so it won't work without another step from the user.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants