Skip to content

airbnb lint should not warn on vuex state mutation #3961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 13, 2019
Merged

Conversation

LinusBorg
Copy link
Member

@LinusBorg LinusBorg commented May 8, 2019

@LinusBorg LinusBorg force-pushed the LinusBorg-patch-2 branch from 77309d3 to 9041497 Compare May 16, 2019 17:58
@LinusBorg LinusBorg force-pushed the LinusBorg-patch-2 branch from 9041497 to dc9486c Compare May 16, 2019 17:59
@LinusBorg LinusBorg marked this pull request as ready for review May 16, 2019 18:30
@LinusBorg LinusBorg self-assigned this May 17, 2019
@haoqunjiang
Copy link
Member

Just realized this config can be added to @vue/eslint-config-airbnb rather than the eslint plugin… And tests are not mandatory for config packages.

@LinusBorg
Copy link
Member Author

Understood, will make the changes

@LinusBorg LinusBorg removed their assignment Jun 1, 2019
@LinusBorg
Copy link
Member Author

@sodatea I moved the change to the config-aribnb package as discussed.

Though technically this could be considered a breaking change if we are very picky.

@haoqunjiang
Copy link
Member

Why?
In regard to ESLint configs, it is only a breaking change when it breaks people's builds. But loosening a rule won't cause more build failures.

@LinusBorg
Copy link
Member Author

In that regard I agree.

If someone is pedantic about what kind of code is committed, they now have a rule pass that might have failed before.

But I agree that's so minimal, especially in the context of the change, we can discard it.

@haoqunjiang haoqunjiang merged commit cb47a28 into dev Jun 13, 2019
@LinusBorg LinusBorg deleted the LinusBorg-patch-2 branch July 28, 2019 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AirBnb ESLint config, no-param-reassign warning in vuex mutation
2 participants