Skip to content

Add warning unknown route #1022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Dec 19, 2016
Merged

Conversation

staskjs
Copy link

@staskjs staskjs commented Dec 16, 2016

Add warning about not existing route, because "Cannot read property 'path' of undefined" is really not informative.

@posva
Copy link
Member

posva commented Dec 17, 2016

Thanks for this!
Can you please surround the warn with a check like

if (process.env.NODE_ENV !== 'production') {
and add a test?

@staskjs
Copy link
Author

staskjs commented Dec 18, 2016

OFFTOPIC: Does owner receive notifications about adding commits to pull request?

In case of not, done.

@LinusBorg
Copy link
Member

Does owner receive notifications about adding commits to pull request?

Nope, no notification. Commenting like you did is a good practice.

@posva
Copy link
Member

posva commented Dec 19, 2016

I did receive a notification for your commit

@LinusBorg
Copy link
Member

Oh... ^^

@posva
Copy link
Member

posva commented Dec 19, 2016

Thanks @LinusBorg 😆

@posva posva merged commit 37326ca into vuejs:dev Dec 19, 2016
@staskjs staskjs deleted the add-warning-unknown-route branch December 19, 2016 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants