[en] typos #1780
Merged
[en] typos #1780
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
posva
requested changes
Oct 3, 2017
|
Sorry for the changes without confirmation. But I found many "Webpack" with uppercases in other docs like |
|
@Jinjiang no worries! 👌 |
|
I had a check. The word in official website of webpack are all with lowercases. So I think the lowercase is right. |
|
It should also be lowercase when it's the first word in the sentence 😆 (https://webpack.js.org/support/#cto-s-vps-owners). Don't worry, I changed it |
posva
approved these changes
Oct 3, 2017
JounQin
reviewed
Oct 9, 2017
| if (err) { | ||
| console.log('We cannot open "index.htm" file.') | ||
| console.log('We cannot open 'index.htm' file.') |
There was a problem hiding this comment.
It should be "index.htm" actually.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
history-mode.md, just because the others all use single quotes.Thanks.