Skip to content

fix: enabled slots option to take class components #826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 15, 2018
Merged

fix: enabled slots option to take class components #826

merged 1 commit into from
Jul 15, 2018

Conversation

nekosaur
Copy link
Contributor

isValidSlot did not consider class components or Vue.extend:ed components.

closes #824

eddyerburgh
eddyerburgh approved these changes Jul 15, 2018
View reviewed changes
Copy link
Member

@eddyerburgh eddyerburgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :)

@eddyerburgh eddyerburgh merged commit 4916fed into vuejs:dev Jul 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eddyerburgh eddyerburgh eddyerburgh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can't use components defined with Vue.extend as slot content when mounting
2 participants
@nekosaur @eddyerburgh