This repository was archived by the owner on Jul 19, 2025. It is now read-only.
feat(compiler-vapor): slot outlet #182
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vapor-template-explorer ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for vapor-repl ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Size ReportBundles
Usages
|
LittleSound
force-pushed
the
feat/compiler-vapor-slot-outlet
branch
3 times, most recently
from
0604691 to
f183394
Compare
sxzz
force-pushed
the
feat/compiler-vapor-slot-outlet
branch
3 times, most recently
from
31e2c91 to
355d15f
Compare
sxzz
suggested changes
Apr 28, 2024
sxzz
suggested changes
Apr 28, 2024
|
When using |
|
There's an error on non-Vapor mode https://template-explorer.vuejs.org/#eyJzcmMiOiI8c2xvdCB2LXNob3c9XCJva1wiIC8+Iiwib3B0aW9ucyI6e319 
|
LittleSound
force-pushed
the
feat/compiler-vapor-slot-outlet
branch
2 times, most recently
from
babfe1b to
25ff0df
Compare
|
You are right, I was sloppy 🤪. fixed. |
sxzz
reviewed
May 2, 2024
LittleSound
force-pushed
the
feat/compiler-vapor-slot-outlet
branch
from
e1478e2 to
1609cda
Compare
sxzz
reviewed
May 2, 2024
Comment on lines
22
to
23
| push(NEWLINE, `const n${id} = `) | ||
| push( |
<div>
<div v-show="false" />
<slot :a="b" />
</div>Emitted an error, but not expected. |
|
All issues are fixed. |
sxzz
approved these changes
May 2, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #154
Related runtime PR: #170