IE should prefer bound props over static props other than class #1703
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -8,6 +8,15 @@ var empty = {} | |||
| var identRE = require('../parsers/path').identRE | |||
| var settablePathRE = /^[A-Za-z_$][\w$]*(\.[A-Za-z_$][\w$]*|\[[^\[\]]+\])*$/ | |||
|
|
|||
| // feature detect browsers (IE) that have trouble | |||
| // with binding syntax on certain attributes | |||
| var div, preferBinding | |||
There was a problem hiding this comment.
Let's move this check in to util/env.js and expose it as _.preferBinding.
|
|
yyx990803
added a commit
that referenced
this pull request
Nov 4, 2015
IE should prefer bound props over static props other than class
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A follow on from: #1639
There are more attributes other than
titlewhich IE has issues with. (id,lang,language,dir, etc)e.g: http://codepen.io/anon/pen/yYxBPy
In this PR, we feature detect binding syntax issues, if the current browser does have this issue, we check every prop for a bound alternative, (
:,v-bind:,*.sync,*.once) and if present, use the bound prop over a static prop.classis ignored. Buy ignoring it the behavior matches other browsers (bound classes get passed down to component root element)