Better user error. #134
Merged
Better user error. #134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return function vuexBoundAction (...args) { | ||
| return action.call(this, store, ...args) | ||
| if (Function.prototype.isPrototypeOf(action)) { |
There was a problem hiding this comment.
I think just typeof action === 'function' is simpler.
| */ | ||
|
|
||
| function makeBoundAction (store, action) { | ||
| function makeBoundAction (store, action, key) { | ||
| return function vuexBoundAction (...args) { |
There was a problem hiding this comment.
actually, we should do the typeof action check and warn in makeBoundAction before returning the bound action. This way the user gets the warning right at instance creation time instead of when they actually call the action.
There was a problem hiding this comment.
You're right! I just pushed a fix.
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposal on how to fix #121. Feedback appreciated.