#1591 refactor: do not mutate mutation payload in the todo app example #1670
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmmm... test is failing. It passes at local env so it might be timing issue... We should look into the e2e test to be more stable. |
kiaking
force-pushed
the
1591-refactor-todo-example
branch
from
36300c1 to
cce1519
Compare
|
OK now test is passing. |
ktsn
reviewed
Jan 27, 2020
examples/todomvc/store/mutations.js
Outdated
| @@ -15,7 +15,6 @@ export const mutations = { | |||
| }, | |||
|
|
|||
| editTodo (state, { todo, text = todo.text, done = todo.done }) { | |||
| todo.text = text | |||
| todo.done = done | |||
| state.todos.splice(state.todos.indexOf(todo), 1, { ...todo, text, done }) | |||
There was a problem hiding this comment.
Can we refactor it for readability? Having everything on one line looks a bit too packed.
Suggested change
| state.todos.splice(state.todos.indexOf(todo), 1, { ...todo, text, done }) | |
| const index = state.todos.indexOf(todo) | |
| state.todos.splice(index, 1, { | |
| ...todo, | |
| text, | |
| done | |
| }) |
vaga
pushed a commit
to vaga/vuex
that referenced
this pull request
Apr 20, 2020
…js#1670) * refactor: do not mutate mutation payload in the todo app example * refactor: make things a bit easier to read
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #1591
This PR refactors the mutation logic in todo example to not mutate mutation payload directly in the simplest form.
It's still using the reference to todo (at
indexOf) but I think it's more clearer than before that Vuex recommends to not mutate payload directly.