-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
fix docs description #1679
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix docs description #1679
Conversation
Yeah, you're right. It says action, but the code example is actually committing a mutation. It's bit confusing. But however, the word "action" could sound like it's referring to a method or function. So to get rid of this confusion, how about renaming it to "method" instead? Also, we need to change all other langs as well 😝 |
Hi king, i found that problem had been fixed in the master branch. But the online docs is using the dev branch. So what can i help😝 @kiaking |
Oh, thank you so much for the check! Let me check how doc deploy things work 🤔 I'll come back to you. |
@PeterChen1997 OK I've checked. Well currently, But I think docs are managed by community members mainly, could you change the word |
I think this 'action' maybe is not the action in Vuex? Maybe using 'mutation' in docs is more specific I check the englinsh docs, and it's the same word 'action'... Maybe I misunderstand the mean docs: fix docs desc in forms part
2e9b500
to
28284a5
Compare
@kiaking Thx for your patient reply, i had fixed the docs' problem in chinese and english version. If there is any problem, you can call me back~ |
@PeterChen1997 Thanks a bunch! 👍 @ktsn Could you final check this? I think this change would make more sense and reduce users confusion. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Nice! Let's merge this baby then 👍 Thank you so much for your contribution @PeterChen1997 🎉 |
I think this 'action' maybe is not the action in Vuex? Maybe using 'mutation' in docs is more specific
I check the englinsh docs, and it's the same word 'action'...
Maybe I misunderstand the mean