Skip to content

docs(ja): add hasModule api translation #1722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 23, 2020
Merged

docs(ja): add hasModule api translation #1722

merged 1 commit into from
Apr 23, 2020

Conversation

kiaking
Copy link
Member

@kiaking kiaking commented Apr 21, 2020

This PR add the Japanese translation for the new hasModule API.

@kiaking kiaking added the documentation Improvements or additions to documentation label Apr 21, 2020
@kiaking kiaking requested review from kazupon and ktsn April 21, 2020 16:36
@kiaking kiaking self-assigned this Apr 21, 2020
kazupon
kazupon approved these changes Apr 22, 2020
View reviewed changes
Copy link
Member

@kazupon kazupon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@kiaking kiaking merged commit 52b753b into dev Apr 23, 2020
@kiaking kiaking deleted the docs-ja-has-module-api branch April 23, 2020 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ktsn ktsn Awaiting requested review from ktsn

1 more reviewer

@kazupon kazupon kazupon approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@kiaking kiaking

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kiaking @kazupon