Skip to content
This repository was archived by the owner on May 13, 2024. It is now read-only.

Conversation

Kocal
Copy link
Contributor

@Kocal Kocal commented Mar 8, 2020

Summary

When the custom font PT Serif is downloading, headings are not visible until the custom font is downloaded.
This is what we call Flash Of Invisible Text (FOIT).

To prevent this, we cant set @font-display: swap to:

  • use the fallback font when PT Serif is being downloaded
  • use PT Serif when it's downloaded

This is called Flash on Unstyled Text (FOUT), and it's preferable over FOIT since you can directly see the content.

Read more at: https://css-tricks.com/font-display-masses/

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe:

If changing the UI of default theme, please provide the before/after screenshot:

.

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

You have tested in the following browsers: (Providing a detailed version will be better.)

  • Chrome 80.0.3987.116
  • Firefox
  • Safari
  • Edge
  • IE

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature
  • Related documents have been updated
  • Related tests have been updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:

Copy link
Member

@billyyyyy3320 billyyyyy3320 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@billyyyyy3320 billyyyyy3320 merged commit a9c6cd5 into vuepress:master Mar 9, 2020
@Kocal Kocal deleted the imp/font-loading branch March 9, 2020 07:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants