feat(lib): Cross-platform compatability #6
Conversation
BenBeattieHood
force-pushed
the
cross-platform-compat
branch
from
d6f2e12 to
0161d11
Compare
|
(cc @vvo) |
|
@BenBeattieHood Thanks! Do you have experience in testing CDK constructs? Only asking because a good way to ensure your work and mine will not break in the future would be to setup an example CDK construct and build it on windows/linux on GitHub actions. |
src/NodejsFunction.ts
Outdated
| @@ -123,15 +123,17 @@ export class NodejsFunction extends lambda.Function { | |||
| }; | |||
| }, {}); | |||
|
|
|||
| const nodeifyPath = (path: string) => path.replace(/\\/g, '\\\\'); | |||
There was a problem hiding this comment.
Can you explain why this is needed + add a comment maybe? Thanks!
There was a problem hiding this comment.
Done 👍 good call out.
Only a little, and only a little on GitHub actions too. This might change next year, but sorry not to be of much use right now. |
|
🎉 This PR is included in version 1.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
I needed to run your superb npm package on Windows, so would like to propose these small changes to allow this please.