QAT Virtual Machine Virtual Function Support #4375
Conversation
(8086:37c9)
(8086:37c9)
Update comment
smith-daniels
requested review from
dmbaturin,
sarthurdev,
jestabro,
sever-sever and
c-po
|
❌ |
|
CI integration 👍 passed! Details
|
| # 0435 -> DH895 | ||
| # 6f54 -> D15xx | ||
| # 18ee -> QAT_200XX | ||
| data = re.findall( | ||
| '(8086:19e2)|(8086:37c8)|(8086:0435)|(8086:6f54)|(8086:18ee)', output) | ||
| '(8086:19e2)|(8086:37c8)|(8086:37c9)|(8086:0435)|(8086:6f54)|(8086:18ee)', output) |
There was a problem hiding this comment.
From a purely aesthetic point of you, the diff might have looked better if the new value was added after 8086:0435. But I have nothing against the substance.
There was a problem hiding this comment.
I thought because it was a subset of the physical C62xx physical device that if fit directly after that, but I understand your point from the perspective of reading the code change. I will squash the commits for this as requested.
There was a problem hiding this comment.
PR Overview
This pull request fixes a bug in QAT detection by adding support for the Intel QAT Virtual Function PCI ID (8086:37c9) in the regular expressions used for scanning devices. Changes include updating regex patterns in both the operational and configuration modes and refining related inline comments.
Reviewed Changes
| File | Description |
|---|---|
| src/op_mode/show_acceleration.py | Updated regex patterns and command output to include PCI ID 8086:37c9; fixed a comment typo. |
| src/conf_mode/system_acceleration.py | Updated regex pattern and added a comment to document the new QAT PCI ID. |
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
src/op_mode/show_acceleration.py:95
- Correct the spelling of 'availible' to 'available' in the comment.
# Show availible Intel QAT devices
There was a problem hiding this comment.
One thing: could you include a task number in the commit and PR titles? If there's no task, create one in https://vyos.dev
|
A reminder: please create a task in vyos.dev if it's not there and include the number in the commit message and the PR title. Without that we cannot move this forward. |
QAT Virtual Function Detection
Types of changes
Related Task(s)
Related PR(s)
How to test / Smoketest result
root@VyOS01:/home/vyos# adf_ctl status
Checking status of all devices.
There is 4 QAT acceleration device(s) in the system:
qat_dev0 - type: c6xxvf, inst_id: 0, node_id: 0, bsf: 0000:05:00.0, #accel: 1 #engines: 1 state: up
qat_dev1 - type: c6xxvf, inst_id: 1, node_id: 0, bsf: 0000:0c:00.0, #accel: 1 #engines: 1 state: up
qat_dev2 - type: c6xxvf, inst_id: 2, node_id: 0, bsf: 0000:14:00.0, #accel: 1 #engines: 1 state: up
qat_dev3 - type: c6xxvf, inst_id: 3, node_id: 0, bsf: 0000:1c:00.0, #accel: 1 #engines: 1 state: up
root@VyOS01:/home/vyos# lspci -nn
.......
03:00.0 Serial Attached SCSI controller [0107]: VMware PVSCSI SCSI Controller [15ad:07c0] (rev 02)
04:00.0 Ethernet controller [0200]: VMware VMXNET3 Ethernet Controller [15ad:07b0] (rev 01)
05:00.0 Co-processor [0b40]: Intel Corporation C62x Chipset QuickAssist Technology Virtual Function [8086:37c9] (rev 04)
0b:00.0 Ethernet controller [0200]: VMware VMXNET3 Ethernet Controller [15ad:07b0] (rev 01)
0c:00.0 Co-processor [0b40]: Intel Corporation C62x Chipset QuickAssist Technology Virtual Function [8086:37c9] (rev 04)
0d:00.0 Ethernet controller [0200]: VMware VMXNET3 Ethernet Controller [15ad:07b0] (rev 01)
13:00.0 Ethernet controller [0200]: VMware VMXNET3 Ethernet Controller [15ad:07b0] (rev 01)
14:00.0 Co-processor [0b40]: Intel Corporation C62x Chipset QuickAssist Technology Virtual Function [8086:37c9] (rev 04)
1b:00.0 Ethernet controller [0200]: VMware VMXNET3 Ethernet Controller [15ad:07b0] (rev 01)
1c:00.0 Co-processor [0b40]: Intel Corporation C62x Chipset QuickAssist Technology Virtual Function [8086:37c9] (rev 04)
Checklist: