Skip to content

T7396: Return the old script to generate tech-support archive #4472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: current
Choose a base branch
from

Conversation

sever-sever
Copy link
Member

@sever-sever sever-sever commented Apr 25, 2025

Change summary

Return the old script to generate tech-support archive command, introduced in #3746
The machine-readable format is good, but useless for analysis. There are no logs and other necessary information.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe): Return old script to generate tech-support arcive

Related Task(s)

Related PR(s)

How to test / Smoketest result

Before changes, we got JSON format which is not good to analyse the system issue.

vyos@r14:~$ generate tech-support archive 
vyos@r14:~$ 
vyos@r14:~$ ls -lah | grep json
-rw-r--r-- 1 vyos users  57K Apr 25 12:29 .json.gz
vyos@r14:~$ 

After the change, we get the required format:

vyos@r14:~$ generate tech-support archive 
Debug file is generated and located in /tmp/r14_tech-support-archive_2025-04-25T12-34-47.tar.gz
vyos@r14:~$ 
vyos@r14:~$ ls -lah /tmp | grep gz
-rw-r--r-- 1 root root      4.3M Apr 25 12:35 r14_tech-support-archive_2025-04-25T12-34-47.tar.gz
vyos@r14:~$ 

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

Return the old script to 'generate tech-support archive' command.
The machine-readable format is good, but useless for analysis.
There are no logs and other necessary information.
@sever-sever sever-sever requested review from dmbaturin and zdc April 25, 2025 09:43
Copy link

github-actions bot commented Apr 25, 2025

👍
No issues in PR Title / Commit Title

Copy link

CI integration 👍 passed!

Details

CI logs

  • CLI Smoketests (no interfaces) 👍 passed
  • CLI Smoketests (interfaces only) 👍 passed
  • Config tests 👍 passed
  • RAID1 tests 👍 passed
  • TPM tests 👍 passed

@sever-sever sever-sever marked this pull request as draft April 25, 2025 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

1 participant