Skip to content

session: T6696: 'clear session' to 'reset session' #4476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: current
Choose a base branch
from

Conversation

ryanzuwala
Copy link
Contributor

@ryanzuwala ryanzuwala commented Apr 26, 2025

Rename config node from clear-session to reset-session

Change summary

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe): Rename CLI syntax from clear session to reset session

Related Task(s)

https://vyos.dev/T6696

Related PR(s)

How to test / Smoketest result

Attempt to run clear session tty1 and an error message should display. Running reset session tty1 performs this task now.

reset-session-cli

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

Rename config node from clear-session to reset-session
Copy link

github-actions bot commented Apr 26, 2025

👍
No issues in PR Title / Commit Title

@ryanzuwala
Copy link
Contributor Author

Documentation PR: vyos/vyos-documentation#1630

Copy link

CI integration 👍 passed!

Details

CI logs

  • CLI Smoketests (no interfaces) 👍 passed
  • CLI Smoketests (interfaces only) 👍 passed
  • Config tests 👍 passed
  • RAID1 tests 👍 passed
  • TPM tests 👍 passed

Copy link
Member

@sever-sever sever-sever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename seems reasonable.

@sever-sever sever-sever requested a review from dmbaturin April 26, 2025 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants