Make Client.postMessage to unloaded client not throw #1293
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cf834f0 clarified the target object can be null, and it must throw in that case. But #1291 pointed out that we cannot implement that behavior without blocking the service worker process in multi-process browser architectures. This change makes the control return right away if the target client has been unloaded. Fixes #1291.
|
@wanderview, does https://github.com/w3c/ServiceWorker/pull/1293/files#diff-27b79860afe28f01aed4f1f6228367faR1033 work for you? Chromium checks if the client is available when the request is getting through the browser process: https://cs.chromium.org/chromium/src/content/browser/service_worker/service_worker_version.cc?type=cs&q=ServiceWorkerVersion::PostMessageToClient&l=1155. /cc @mattto |
jakearchibald
requested changes
Oct 4, 2018
docs/index.bs
Outdated
| 1. If |destination| is null, <a>throw</a> an "{{InvalidStateError}}" {{DOMException}}. | ||
| 1. Let |serializeWithTransferResult| be <a abstract-op>StructuredSerializeWithTransfer</a>(|message|, |transfer|). Rethrow any exceptions. | ||
| 1. Add a <a>task</a> that runs the following steps to |destination|'s [=ServiceWorkerContainer/client message queue=]: | ||
| 1. Let |targetClient| be the [=context object=]'s [=Client/service worker client=], or null if it does not exist (i.e. if the [=/service worker client=] has been [=Handle Service Worker Client Unload|unloaded=]). |
There was a problem hiding this comment.
I'm not sure what "or null if it does not exist" means. Have we defined how to check for existence? If so we should link to that. Also, is it ok to perform this existence check on the main thread?
There was a problem hiding this comment.
@jakearchibald, I pushed a commit to address these points. PTAL.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cf834f0
clarified the target object can be null, and it must throw in that case.
But #1291 pointed out that we
cannot implement that behavior without blocking the service worker
process in multi-process browser architectures.
This change makes the control return right away if the target client has
been unloaded.
Fixes #1291.
Preview | Diff