Skip to content

Editorial: Removed aria-controls from the states and properties table for the combobox role to align with the combobox role definition. #2583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 21, 2025
Merged

Editorial: Removed aria-controls from the states and properties table for the combobox role to align with the combobox role definition. #2583

merged 2 commits into from
Aug 21, 2025

Conversation

giacomo-petri
Copy link
Contributor

@giacomo-petri giacomo-petri commented Jul 24, 2025 •
edited by pr-preview bot
Loading

Closes #2582

Removed aria-controls from the states and properties table for the combobox role to align with the combobox role definition.

Preview | Diff

@giacomo-petri
Removed aria-controls from the states and properties table for the co…
5b43259 
…mbobox role to align with the combobox role definition.
@netlify Netlify
Copy link

netlify bot commented Jul 24, 2025 •
edited
Loading

✅ Deploy Preview for wai-aria ready!

Name Link
🔨 Latest commit 89bec08
🔍 Latest deploy log https://app.netlify.com/projects/wai-aria/deploys/688277600ce5ad00080fece2
😎 Deploy Preview https://deploy-preview-2583--wai-aria.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@spectranaut spectranaut changed the title Removed aria-controls from the states and properties table for the combobox role to align with the combobox role definition. Editorial: Removed aria-controls from the states and properties table for the combobox role to align with the combobox role definition. Jul 31, 2025
@spectranaut spectranaut added the editorial a change to an example, note, spelling, grammar, or is related to publishing or the repo label Jul 31, 2025
@spectranaut spectranaut requested review from jnurthen and pkra July 31, 2025 17:07
jnurthen
jnurthen approved these changes Aug 12, 2025
View reviewed changes
Copy link
Member

@jnurthen jnurthen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

smhigley
smhigley reviewed Aug 19, 2025
View reviewed changes
pkra
pkra approved these changes Aug 21, 2025
View reviewed changes
@pkra pkra merged commit 5b53575 into main Aug 21, 2025
9 checks passed
@github-project-automation github-project-automation bot moved this from Needs Review to Reviewed, need PR checklist item in ARIA Editorial (Spec Prose Updates) PR Tracking Aug 21, 2025
github-actions bot added a commit that referenced this pull request Aug 21, 2025
@giacomo-petri @github-actions
Editorial: Removed aria-controls from the states and properties table…
c31f032 
… for the combobox role to align with the combobox role definition. (#2583)

SHA: 5b53575
Reason: push, by pkra

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smhigley smhigley smhigley left review comments

@pkra pkra pkra approved these changes

@jnurthen jnurthen jnurthen approved these changes

Assignees
No one assigned
Labels
editorial a change to an example, note, spelling, grammar, or is related to publishing or the repo spec:aria
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove typo of required aria-controls for combobox in states and properties table
5 participants
@giacomo-petri @pkra @jnurthen @smhigley @spectranaut