Skip to content

Conversation

nondebug
Copy link
Collaborator

@nondebug nondebug commented Dec 8, 2022

Closes #???

The following tasks have been completed:

  • Modified Web platform tests (link to pull request)

Implementation commitment:


Preview | Diff

Copy link
Member

@marcoscaceres marcoscaceres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an improvement, but I don't think this is exactly right... I think we should use #136 here..

I think what we actually want is:

  • The model says there is a conceptual gamepads 🎮🎮🎮 representing real (or conceptual) things.
  • When .getGamepads() is called, we go to the model and "snapshot" each conceptual gamepad (i.e., make the lists, copy stuff from the conceptual ones).
  • return the result.

Right now, this reads like we are recycling what is normally returned by .getGamepads().

I'm approving, but let's move to using the model.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants