Make eventInitDict param optional in GamepadEvent constructor #217
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| interface GamepadEvent: Event { | ||
| constructor(DOMString type, GamepadEventInit eventInitDict); | ||
| constructor(DOMString type, optional GamepadEventInit eventInitDict = {}); |
There was a problem hiding this comment.
We probably need to remove the required from GamepadEventInit's gamepad.
There was a problem hiding this comment.
Blink, Gecko, WebKit agree that GamepadEventInit's gamepad attribute is optional and nullable, let's update the spec to match.
Gamepad? gamepad; // blink
Gamepad? gamepad = null; // Gecko
Gamepad? gamepad = null; // WebKit
|
Should the type of the |
|
@tcl3, yes, good catch. I think the attributes are required to mirror the value they are initialized with. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #216
The following tasks have been completed:
Implementation commitment:
Preview | Diff