Issue with order of processing nesting keys in Expansion

[kasei]

Test tn004 seems to rely on nesting keys being processed in lexicographic order. However, Expansion step 14 does not specify any order on the iteration:

For each key nesting-key in nests

I believe this should instead be:

For each key nesting-key in nests ordered lexicographically

[gkellogg]

Could be optionally ordered as other loops do, but not necessary for interop, given instructions on comparing results.

[kasei]

@gkellogg doesn't tn004 depend on the ordering here?

[gkellogg]

If you see the note on JSON-LD Object comparison, it says that arrays are compared without regard to order. Of course it also says that if the ordered flag is true, you can use simple object comparison, so adding the ordering text would be predicated on the ordered option.

[gkellogg]

@kasei I added words to order nesting-key if ordered is true.

As always, please respond if this satisfies your concern.

[kasei]

#297 looks reasonable, thanks.

I had missed the wording about test comparisons and instead got caught up by the title of the test ("Test tn004 Appends nested values from all @nest aliases in term order"; emphasis added). Am I misunderstanding the implication of the title? Or should it be updated?

[gkellogg]

Yes, the "in term order" should be dropped from that test entry, as it's inconsistent with the optional ordering of the algorithm. Ordering can be very expensive, and prohibits many streaming implementations.